Skip to content

Themeable ItemCollectionMapperComponent and CollectionItemMapperComponent#4052

Open
jensvannerum wants to merge 4 commits intoDSpace:mainfrom
atmire:themed-ItemCollectionMapperComponent-CollectionItemMapperComponent_contribute-main
Open

Themeable ItemCollectionMapperComponent and CollectionItemMapperComponent#4052
jensvannerum wants to merge 4 commits intoDSpace:mainfrom
atmire:themed-ItemCollectionMapperComponent-CollectionItemMapperComponent_contribute-main

Conversation

@jensvannerum
Copy link
Contributor

Description

This PR makes the ItemCollectionMapperComponent and CollectionItemMapperComponent themeable by default,

Instructions for Reviewers

Enable the "custom" theme and for both components, make some modifications to the component in the custom theme that are obvious.

The ItemCollectionMapperComponent is visible at: Edit Item -> Collection Mapper
The CollectionItemMapperComponent is visible at: Edit Collection -> Item Mapper

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added themes 1 APPROVAL pull request only requires a single approval to merge labels Mar 5, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release Mar 5, 2025
@github-actions
Copy link

Hi @jensvannerum,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge merge conflict themes

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants